Dmitry Panov

Results 70 comments of Dmitry Panov

Sorry, I haven't got the chance to review the code yet, but I would merge it assuming good maintainability and minimum performance impact when debugging is not enabled. As for...

`atob` is not part of ECMAScript specification and therefore is out of scope of this project. To create a string you should use (*Runtime).ToValue() method.

Hi @Cretezy, not sure what you mean. The way you would normally do it in ECMAScript 5, like this for example: http://jsbin.com/rolojuhuya/1/edit?js,console

Your code should be written as this: ```go // Setup v, err := vm.RunString("(function(cb) { return new Promise(cb); })") if err != nil { panic(err) } promiseConstructor, ok := goja.AssertFunction(v)...

You should not do anything special as long as you use `Run*()` methods and the result of `AssertFunction()`. During a normal run the VM stack is not cleared, however when...

Run a soak test and do memory profiling. Runtimes should be garbage-collected as long as you are no longer referencing them.

Hi. You can pass immutable `Value` between runtimes (essentially everything except `*Object`).

Certainly. Please clarify which bit of the documentation got you confused.

Customising the conversion to and from a Value seems like a popular request (see #392 as well), but I haven't quite figured out how to do it properly yet. With...

You can implement a simple JS function and export it to Go. It would be trivial to expose `instanceOfOperator` except for one thing: error handling. I've realised there is a...