Niall Dooley

SSH Instructions out of date?

2

The SSH instructions state to use the following command to export the public key for access to services such as Github. > $ trezor-agent -v -e ed25519 [email protected] > ~/.ssh/github.pub...

Does not work in specific special buffer

1

`ctrlf` does not work in specific special buffers. For example, it works in `*scratch*`, `*Messages*`, the orga-agenda buffers that are opened for each `org-agenda-custom-commands` etc. However, it does not work...

rye shell does not activate environment but does set VIRTUAL_ENV

6

### Steps to Reproduce 1. Create a `rye` managed python project `rye init rye-demo` 2. Navigate into this project directory `cd rye-demo` 3. Execute `rye sync` 4. Execute `rye shell`...

### Steps to Reproduce I have the following line in `~/.bash_completion` which is sourced by `~/.bashrc` for additional completions. ````shell eval "$(register-python-argcomplete pipx)" ```` This is how one is instructed...

I put my AWS access key credentials in my password-store rather than keep in the default cleartext. I added them to my password-store using the `aws-vault add` command with the...

KeepKey device defined as a Trezor device

2

https://github.com/romanz/trezor-agent/blob/3c911e99a0394278104564092225d67c75e74b99/libagent/device/keepkey.py#L20 Should this not be: ````python class KeepKey(interface.Device): ````

Does KeepKey support GPG?

10

https://github.com/romanz/trezor-agent/blob/3c911e99a0394278104564092225d67c75e74b99/agents/keepkey/setup.py#L7 Suggests it does. https://github.com/romanz/trezor-agent/blob/3c911e99a0394278104564092225d67c75e74b99/agents/keepkey/setup.py#L35-L37 Yet, there appears to be no GPG entry points defined. https://github.com/romanz/trezor-agent/blob/3c911e99a0394278104564092225d67c75e74b99/agents/keepkey/keepkey_agent.py#L1-L5 L1 imports the GPG module but there are then no `gpg_tool` or `gpg_agent` lambda...

Rename NotFoundError exception to DeviceNotFoundError

1

This would be in keeping with the naming of built-in exceptions such as: FileNotFoundError ModuleNotFoundError

Apply consistent style to imports in the hardware device agent scripts

1

https://github.com/romanz/trezor-agent/blob/3c911e99a0394278104564092225d67c75e74b99/agents/trezor/trezor_agent.py#L1-L8 The style here is inconsistent with the other hardware device agent scripts. See below. If you have a preferred style I can submit a PR. https://github.com/romanz/trezor-agent/blob/3c911e99a0394278104564092225d67c75e74b99/agents/keepkey/keepkey_agent.py#L1-L5 https://github.com/romanz/trezor-agent/blob/3c911e99a0394278104564092225d67c75e74b99/agents/jade/jade_agent.py#L1-L7 https://github.com/romanz/trezor-agent/blob/3c911e99a0394278104564092225d67c75e74b99/agents/ledger/ledger_agent.py#L1-L7 https://github.com/romanz/trezor-agent/blob/3c911e99a0394278104564092225d67c75e74b99/agents/onlykey/onlykey_agent.py#L1-L7...

ECDH curve hard-coded

2

https://github.com/romanz/trezor-agent/blob/3c911e99a0394278104564092225d67c75e74b99/libagent/gpg/protocol.py#L175 This corresponds to `curve25519`. Now my primary key uses the `nistp256` curve so I can assume this constant had a different value at some point. Would it not be...