KeepKey device defined as a Trezor device

Open doolio opened this issue 2 years ago • 2 comments

https://github.com/romanz/trezor-agent/blob/3c911e99a0394278104564092225d67c75e74b99/libagent/device/keepkey.py#L20

Should this not be:

class KeepKey(interface.Device):

Sep 11 '23 10:09 doolio

I used inheritance to re-use TREZOR agent implementation with KeepKey class.

Sep 17 '23 15:09 romanz

Right. I guess I was curious to why this was done for the KeepKey and not the other hardware devices. Feel free to close this if you don't wish to change how this is implemented. If you would like to align the KeepKey device with the others for consistency then I could submit a PR for consideration.

Sep 18 '23 08:09 doolio