Niall Dooley

Results 170 comments of Niall Dooley

Right. I guess I was curious to why this was done for the KeepKey and not the other hardware devices. Feel free to close this if you don't wish to...

OK but the line I quoted is from the generic `libagent` library so it it defines the ECDH key exchange algorithm used ad hardcodes it. It seems it can either...

Any further thought given to this?

I only have a Trezor T.

That would explain the current state. Is it a matter of simply adding the entry points and the lambda functions I discuss above? If so I can submit such a...

Hmm ok. I only have a trezor T so can't help with such tests.

You're right of course. I'm just highlighting potential issues where I see them.

OK if that is the case then should we reconsider the naming in other places to be more accurate and prevent confusion. For example here: https://github.com/romanz/trezor-agent/blob/3c911e99a0394278104564092225d67c75e74b99/libagent/formats.py#L1 Firstly, the doctsring for...

The `curve_name` naming here is also misleading if the default value is correct. https://github.com/romanz/trezor-agent/blob/3c911e99a0394278104564092225d67c75e74b99/libagent/age/client.py#L15

@romanz any further thoughts on the other issues I raised above?