Ilya Brin
Ilya Brin
@pk11 Hey, could you take another look at this and merge/release when you get the chance? FWIW looks like https://github.com/pk11/sedis/pull/4 was trying to solve the same issue, can probably close...
> @dontgitit what about Tuple3, Tuple4, etc.? Is Tuple2 much more of a need and if so why? Tuple3 etc would be great too. I think one realistic use of...
Sounds plausible, but I don't have the bandwidth to work on it unfortunately
Could you take a look @sstone ? Is this PR reasonable?
Nice, this looks a lot more comprehensive than `collect`/`collectReferenceParameters` (and in fact would probably be trivial to re-implement those two by using this)
Hey @jknack , we need this because we'd like to essentially verify some things before we render the `Template`. `collect` gets us part of the way there (gives us the...
And no, we added the built `jar` to use in our own project until this makes its way into one of your builds; certainly do not commit the `.jar` to...
@jknack `Param` is an internal class, but maybe we should expose it, rather than changing it to `List getParams`? Reasons: 1.) `Param` encodes important metadata, such as the parameter type...
hey @jknack , finally got around to making the changes you suggested! let me know how it looks... I marked `collect` as deprecated rather than `collectReferenceParameters`, since `collect` does pretty...
hey @jknack , wondering if you have any other thoughts/concerns about this PR, or if we could move it along somehow? thanks!