Donovan Hide

- Use cmov instruction on amd64 for constant time move - FeZero and FeOne unrolled ``` benchmark old ns/op new ns/op delta BenchmarkKeyGeneration-4 64769 55550 -14.23% BenchmarkSigning-4 65107 56922 -12.57%...

Hi, this request might be slightly beyond the scope of this project, but an answer would be very much gratefully received! This post discusses the use of ed25519 and Schnorr...

Incorrect version in self signed certificate

7

https://github.com/ripple/rippled/blob/9d89d4c1885e13e3c0aa7cdb4a389c6fbfd3790a/src/ripple/basics/impl/make_SSLContext.cpp#L159 X.509 certificates can have a version number between 1 and 3 inclusive. The constant `NID_X509` equals 12. The correct constants are one of `X509_VERSION_1`,`X509_VERSION_2` or `X509_VERSION_3`. Maybe this is...

Ubuntu Impish build requires libprotoc-dev package

3

https://xrpl.org/build-run-rippled-ubuntu.html The `libprotoc-dev` package was required to get `cmake ..` to complete.

``` $ curl -s 'https://api.ripplecharts.com/api/offersExercised' -H 'content-type: application/json' --data-binary '{"startTime":"2015-08-12T16:20:59+00:00","endTime":"2015-08-13T16:20:59+00:00","base":{"currency":"XRP"},"counter":{"currency":"USD","issuer":"rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q"},"reduce":false,"format":"csv"}' | head -n2 startTime, baseVolume, counterVolume, count, open, high, low, close, vwap, openTime, closeTime 2015-08-12T16:58:40+00:00, 0.00816949540641152, 122, 0.996678439582205, rGWBfkHZUECBtpSt22donchB263cgAfdhJ, rHsZHqa5oMQNL5hFm4kfLd47aEMYjPstpg,...

Hi, thanks for this package, it really helps with ciphers unsupported by crypto/tls! Here's a small pull request that helps with SSL handshakes with Ripple servers that use ADH ciphers...

Negative LPTokenValue following AMMWithdraw transaction

1

``` rippled -q json amm_info '{"asset":{"currency":"XRP"},"asset2":{"currency":"446F676500000000000000000000000000000000","issuer":"rKRXaQi8wQrYNs3MRHdyFpf3zWRV62xmPa"}}' { "result" : { "amm" : { "account" : "rGzyAVXRUoHR6UWB2GbSeJ55B4Wa1JHFB4", "amount" : "0", "amount2" : { "currency" : "446F676500000000000000000000000000000000", "issuer" : "rKRXaQi8wQrYNs3MRHdyFpf3zWRV62xmPa", "value" :...

Replicate OfferCreate functionality in Payments to Self

2

## Summary I want to use Payments to condense multiple `OfferCreates` into a single `Payment` to self, i.e. a Payment where `Account` and `Destination` are the same. To do this...

Update conan recipe for Snappy using cmake 4

3

The conan recipe for Snappy does not build on OS X using the current homebrew cmake (4.0.1) ``` ... snappy/1.1.10: CMake command: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/Users/donovanhide/.conan/data/snappy/1.1.10/_/_/build/c12dc1aa353511ad32e610282ba7d9d33490d623/build/Release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/Users/donovanhide/.conan/data/snappy/1.1.10/_/_/package/c12dc1aa353511ad32e610282ba7d9d33490d623" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release"...

Account has issued a currency with non standard currency code "XRP".

13

## Issue Description Account has issued a currency with non standard currency code "XRP". ## Steps to Reproduce https://xrpscan.com/account/rPogU2XdDeiycaos1toSLFgoscca2qG2H ## Expected Result temBAD_CURRENCY would be the expected result for a...