Donovan Hide

Thanks for the links to those issues. I tried to follow through the unfinished work in the two PRs with conan 2, but I'm still not having much fun on...

Relevant code is here: https://github.com/XRPLF/rippled/blob/e5aa605742befe585309cb380796fa6d56bb6f04/src/xrpld/app/paths/detail/DirectStep.cpp#L403-L457 I'd argue, once the Auth and NoRipple checks are passed, if Payment's Account is equal to Destination, the line should be created, if it does...

The check for a standard currency code of "XRP" is satisfied, but a check for a non-standard currency code of "XRP" is not. The suffix of `00000000000` in the quoted...

Signed!

For my use case, I will have to hard code this whitelist into my app, as all those listed Currencies will still be tradable, with whatever current issuers, and also...

Are you referring to this? https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0033d-multi-purpose-tokens#a114-why-isnt-mptokenissuanceid-constructed-from-the-hash-of-an-issuer-address-and-currency-code I can't find any reference to the 16 bit mask issue you have just raised in your previous comment. Could you please elucidate?

Why not check if all the bytes are zero except the three standard currency bytes rather than just checking the first two bytes? Then you have completely validated the currency...

I can't really comment on unwritten specs. If you are expecting me as a consumer of rippled binary output to check the first two bytes of a STIssue and then...