Jonas Kahler comments

Results 7 comments of


                                            Jonas Kahler

hdf5: figure out how to resolve the Go pointer to Go pointer issue

SGTM :+1:

Can't open attributes on the root group

Hi @ChaosCA Is it even necessary to open the group your particular example? Can you try to call `f.OpenAttribute("file_version")` and remove the group related code instead? Cheers!

all: moves to camel case naming

Good comments, @kortschak! Thx! I found one more thing that I really dislike. We have some mix-up in the test cases when it comes to `fname` vs. `fName`. I suggest...

HDF5 version 1.10 support?

Will also affect the `H5PT` interface. But the deprecated functions should still work in 1.10, so no big changes needed IMHO.

HDF5 version 1.10 support?

I think this library should not break, as I am running hdf5-dev in version 1.10 on my machine and it just works (I enabled deprecated support when I compiled). Then...

hdf5: first stab at hdf5-1.10 support

That looks good. And to confirm it even further. We are running this lib for quite some time now on HDF5 v1.10.1 without any issues.

Environment variables not being set correctly in go_binary debug

I am facing the exact same issue, both when it comes to the environment variables passed as part of ```go load("@rules_go//go:def.bzl", "go_binary") go_binary( name = "my_binary", embed = [":my_library"], env...