Dongsu Park

Results 129 comments of Dongsu Park

@donbowman Yes, we can document that approach. Anyway to fix this issue, we need to merge https://github.com/kinvolk/kube-spawn/pull/283, which looks good to me. I'm thinking about merging it tomorrow, if there's...

Hmm, I didn't mean to close it. Will reopen it, as there's a documentation issue left.

Ok, it seems to be actually multiple issues. First of all, basically I agree that we should check for more details before loading the overlay kernel module. Maybe then it's...

I would call it a "necessary evil" instead of a "bad path". ;-) Anyway your suggestion of running `docker info` looks good in the docker world.

Hmm, I'm not sure about this. I agree that it would be simpler to remember with human-readable strings. That was our original behavior, until we recently took the current approach....

@donbowman Sorry. This PR slipped through my fingers. How about making a command-line option for the different naming scheme, instead of changing the default one? For example, `--sequential-node-names`. If that...

Yes, I agree. We should do some research to know if it's possible to rely on go-systemd for the purpose.

I totally forgot about this issue. Recently I started to think that we should really make use of DBUS API via go-systemd, instead of running `machinectl`. (especially because of the...

This test works well when we run `./scripts/test-smoke.sh` on our own. Next step would be to run the script automatically when each PR is made. Unfortunately at the moment CI...

Updated. * added tests for creating deployments, services etc. * Fixed a name of Fedora Vagrant image. * Used trap for cleaning up.