kube-spawn
kube-spawn copied to clipboard
kinvolk
Make master/worker be numbered rather than random-string for name.
Rationale: using NodePort, its simpler to remember kube-spawn-cluster-worker-1 than to do a machinectl and find the machine name which was used. The former is invariant across invocations.
Hmm, I'm not sure about this. I agree that it would be simpler to remember with human-readable strings. That was our original behavior, until we recently took the current approach. If we go back to the original behavior again, then we would lose uniqueness in the names. Let me think.
the names are still unique.
kube-spawn-<CLUSTER>-<master|worker>-#
and # is incrementing.
it just allows me to always refer to a worker when using NodePort to come into it, rather than run machinectl to find the IP.
On Thu, 30 Aug 2018 at 10:08, Dongsu Park [email protected] wrote:
Hmm, I'm not sure about this. I agree that it would be simpler to remember with human-readable strings. That was our original behavior, until we recently took the current approach. If we go back to the original behavior again, then we would lose uniqueness in the names. Let me think.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kinvolk/kube-spawn/pull/305#issuecomment-417332597, or mute the thread https://github.com/notifications/unsubscribe-auth/AE5Ok1uYBEAtoL2qdDvNaw8acXdyptkyks5uV_HsgaJpZM4WTX1V .
@donbowman Sorry. This PR slipped through my fingers.
How about making a command-line option for the different naming scheme, instead of changing the default one?
For example, --sequential-node-names.
If that option is given, we use the new human-readable naming scheme.
If not, we stay with the current randomized names.
Would it make sense?
I guess i don't understand what the random one achieves for anyone? Its no more unique.