Yauheni
Yauheni
> Without looking much into the changes in the PR > > > The implementation has a new type of MaksingState called "BufferedMaskingState". BufferedMaskingState is a wrapper around MaskingState, which...
@gavlyukovskiy to elaborate on the motivation to create a separate BufferedMaskingState implementation. Initially I tried to implement the streaming mode inside MaskingState, but there were 2 nuances. The first and...
> Great work! Adde a couple of comments. I think we'll need some more tests to make sure every possible scenario with buffer operations are covered sufficiently. > > Also,...
It also probably makes sense to remove `src/jmh/benchmark-history` folder as the history will be stored somewhere else.