Donald Sharp comments

Results 300 comments of


                                            Donald Sharp

Nhg reuse intf down up

I believe Mark is out of town for a week, which will be after the branch pull

zebra: Remove duplicate host routes for the loopback address

It's not unnecessary. How would you propose to do a `redistribute local` for the matching /32 routes in your case?

Non-advertised Interface Down/Up Impacts OSPF Advertised Routes

Please try with latest code. It is unlikely that anyone will ever fix this in the 7.5.X releases

BGPd: member access within null pointer of type 'struct lysc_node_action'

https://github.com/FRRouting/frr/pull/16074

BGPd: member access within null pointer of type 'struct lysc_node_action'

@MPFuzz sounds like you are trying to do fuzzing stuff. There is already a framework for bgp to do this. Please look at the fuzz branch. It's a bit out...

How to build docs?

Yeah, probably someone could figure this out and make it work. Not necessarily worth our time to go down that path though of figuring out how to let `make html`...

zebra: Don't display the vrf if not using namespace based vrfs

Fixed

lyd_validate_all takes ~6 seconds to run

I have upgraded to 2.1.55 and am now seeing ~.8 seconds to run validation. Definitive improvement but more would be a huge help ``` 2023/05/04 07:27:13.162532 BGP: [M7Q4P-46WDR] vty[31]@(config)# route-map...

lyd_validate_all takes ~6 seconds to run

[frr-yang-models.tar.gz](https://github.com/CESNET/libyang/files/11398242/frr-yang-models.tar.gz) ![bgpd yang](https://user-images.githubusercontent.com/10601296/236230460-5fe24101-78ce-4e20-bfe3-613a6de5f9d7.svg) Here is the frr yang models as well as a flamegraph of ~1 minute of run time of the 3k file read in. ( this takes ~2...

Add some test cases, and some ability to see what is going on in zebra

I changed all_protocol_startup locally and it runs fine. I'll need to investigate when I get a chance