Donald Sharp

As a note this is a resubmittal of #16498 because that work was done by an intern and they have gone back to school and we do not expect them...

How do we get to a situation where a l3vni doesn't have a label? That seems to be the problem right? I'd like to fix that...

so the part that interests me is that by putting this test in, instead of figuring out why the problem occurs, we are left with the situation where FRR may...

I actually think it's an ok way to solve the problem. Perhaps though Louis should spend a few minutes expanding the comments in the code, as that I had to...

fix it to what? I actually disagree that it's vrf default table 100. it's just table 100.

I spent some time talking w/ Mark about this on Friday and I also spent some time testing this fix out. I believe that some of the issues that Mark...

During testing this change introduces these new memory leaks: ``` commit fb23d4e2b364525cfbea7768ac6fe22d69fd1b16 Author: Louis Scalbert Date: Thu Aug 22 11:12:29 2024 +0200 zebra: fix table heap-after-free crash Fix a heap-after-free...

so after some more thought I am pretty happy with this, we need to fix the memory leaks introduced as well as I think we need a topotest for this...

``` 2024-09-04 09:41:14,405 WARNING: topo: r1: zebra exited leaving pidfile /var/run/frr/zebra.pid (562470) r1: zebra has memory leaks: zebra: ## showing active allocations in memory group libfrr zebra: Nexthop : 4...

I know we have other places in the code where we have timers to regenerate data in BGP but I am personally not happy about that approach as that it...