Donald Sharp

I think the json should have the daemon name and the instance name as separate entities not combined

Kernel routes and isis routes have different AD, and as such isis metrics will never be compared to kernel metrics( as if that even means anything) Talking about metric makes...

please squash your commits and remove the merge commit and force push the changes. Then we can move forward here

This commit breaks topotest recording of memory leaked on shutdown. From my perspective this is a pretty big regression. I'd like to discuss what we can do to fix this...

This code change assumes that you are running as a daemon and if you are not you should not just be closing files. Additionally it breaks things like `--log=stdout |...

Can we get a flamegraph of what pim6d is doing at the time it's usage is high? https://github.com/FRRouting/frr/wiki/Perf-Recording

a) Now signed-off-by line.. This must be fixed. b) 1800 + lines of diff in one commit. This is going to be too hard to swallow. It must be broken...

What's the `ip route show 10.0.0.0/8` command give us from the linux command line?

I would be surprised if bfd handles the interface id # change appropriately once it is assigned. I suspect we would need to check a bunch of daemons behaviors. Not...

It might be better to have file only allow the loading of files in the --sysconfdir. Other than that it's an good idea. How do you plan to make this...