Donald Dong

execute_batch returns the result of the last statement

1

Currently `execute_batch` always return `nil`. 1) Would it be better to return the result of the last statement instead? 2) Would it make sense to accept a list of statements...

This is an attempt to address #950. It's probably not a good idea to grep pieces of the default REDIS_URL when it's present. The REDIS_URL could be used when no...

Wrong client default options

1

### Steps to repro ``` REDIS_URL=rediss://:[email protected]:1234 irb ``` ```ruby require 'redis' Redis::Client.new(host: '127.0.0.2') ``` ### Expected A client with default port 6379 with no password ### Actual A client with...

https://github.com/fragglet/c-algorithms/blob/17cd712ef84948ce5c3faae911bc797ebad26e09/src/rb-tree.c#L377 This line should check the keys, not the values. Separately, does this repro accept new features such as implementing the missing deletion functionality in rbtree? Thanks!

Seperate sorbet sigs from rb files

5

This separates the sorbet sigs from rb files so sorbet runtime won't affect the lib code. ### Test Plan - ci

Revisit type validation

1

Related to #42

[feature] Migration#add_index

3

This adds the functionality to run add_index in redcord migration. Added a test case to cover the new behavior.

https://github.com/FB-PLP/traject/pull/4400/files#diff-d8472367c1c3377a8e9773a2887653b3538dbdad96693b4717e5879ae09cdf6fR96-R98

Add migration: add_index / remove_index

1

These migrations allow people to change the index attributes on existing records.