Dominykas Blyžė

Results 69 comments of Dominykas Blyžė

It seems the original issue is now fixed, though - the CORS headers will be set for the default backend when `nginx.ingress.kubernetes.io/enable-cors: "true"` is set. ~~Still trying to figure out...

> Do you mean a Groovy-script? Yes, for starters 😅 j/k, Groovy is fine, yes. > And you can analyze the the payload in an initial stage within you pipeline...

👋 I'd like to see if this can be revisited, please... > Github repo settings can also prevent users from merging PRs Yes, the GH repo settings can enforce that...

> one question that i think needs to be clarified with the desired workflow here is how a pre-release/canary gets promoted to be a stable release. in the official pre-release...

OK so, I opened up a WIP PR: https://github.com/semantic-release/semantic-release/pull/1820 Is there a better way? Also curious if there's any objections to making `getNextVersion` becoming `async`. I'll still need to tighten...

> Example: 1.2.3-alpha.1 can become 1.2.3-alpha.1+1a2b3c4 with the git sha or 1.2.3-alpha.1+1234 with the build number. Although aside from the fact that the semver standard only prescribes, that build metadata...

Thing is the numbering restarts after each rebase. So you could release an alpha.1+beef, alpha.2+f00d, alpha.3+dead and then rebase, resulting in an alpha.1+1337. I'm not against your proposal, and yes...

> But I don't want to create a npm package. The docs say: > List of modules or file paths It can be a simple module (i.e. a js file),...

> Effectively, bots require 0 approvals when they touch certain files [..] but everything else requires a human approval This is almost exactly the use case we're looking into! However,...

Yeah, if you're enforcing the check via GH, then you do get the yellow, but we aren't and we're trying to fit this into existing people's habits and workflows, so...