Dominic

Results 30 comments of Dominic
trafficstars

## Proposal ### Please re-state the problem that we are trying to solve in this issue. We want to: - It will not apply any updates where we try to...

@mananjadhav That proposal won't work in many cases, as mentioned in [my proposal](https://github.com/Expensify/App/issues/39852#issuecomment-2044143831). Some examples where that solution will cause regressions: - When we try to clear an Array key...

> At once we pass either an object or array to merge. So, if the existing value is an object and the new value is not, we'll not continue with...

[Proposal updated](https://github.com/Expensify/App/issues/39852#issuecomment-2044143831) to handle the `Onyx.set` and `Onyx.mergeCollection` too, based on [this expectation update](https://github.com/Expensify/App/issues/39852#issuecomment-2045812413)

## Proposal ### Please re-state the problem that we are trying to solve in this issue. We want to save client side logging and profile trace files to the /Downloads...

## Reviewer Checklist - [x] I have verified the author checklist is complete (all boxes are checked off). - [x] I verified the correct issue is linked in the `###...

@hungvu193 Are https://github.com/Expensify/App/pull/51135#issuecomment-2424826532 and https://github.com/Expensify/App/pull/51135#issuecomment-2451425006 expected? Or are we waiting for BE changes?

I constantly get this error even though I used the correct code. ![Screenshot 2024-11-12 at 15 09 45](https://github.com/user-attachments/assets/29e883cb-6d30-4b29-9cc2-b482ae807523)

`BUG`: If I abandoned the verify flow (wrong magic code then close the RHP) and refreshed, the card automatically turned to have `NOT_ACTIVATED` state But seems like it's this one...

`BUG`: If I entered wrong validate code, I would always got `Card data missing in detail` error like https://github.com/Expensify/App/pull/51135#issuecomment-2451285601 all the time even when I entered the correct code. I...