Michael Dominick

Results 27 comments of Michael Dominick

Saw your comment re Arch in the other PR. That line is removed here as well because it breaks macOS as well as 18.10. I understand if you reject this...

Closing for now. Going to try to special case arch https://github.com/schultyy/os_type

I have no Arch install but this (in theory) handles the Arch case. If someone could test that to be safe that would probably be best. If the macOS changes...

I appreciate that a lot and sorry for all the Github emails I must have generated for you today :)

Yeah, so I did some digging and it looks like any rolling distro is going to have this problem and there are too many of them to catch individually if...

OK, I will make those changes and update the PR after work today.

Got swamped in day job. I'll jump back on this over the weekend. Sorry for the delay.

Hey I'm back from under the lurch here. Which OS does this break? I'm cool with conditional compilation if that solves the issue. Does it? @unlimitedbacon

Actually, this has gotten more complicated on Catalina. Basically by default a ton of the required libs no longer exist. I am not sure macOS support is really worth perusing,...

Hey @infosisio & @unlimitedbacon, I am back in the black and will work on this over the (US) holiday weekend. Please see my question in the PR thread for clarification.