Dom Harrington
Dom Harrington
I've added docs to the readme. I've also removed the connect dependency from the tests. To do this i had to change the tests to execute on the nextTick of...
I see that makes sense. I'm not too familiar with ipv6 addresses. Wouldn't the IPv6 issue already be a problem with this module, if the host header is `Host: ::1`?...
I've removed the invalid host headers and the tests are all still passing even with the portless IPv6 addresses. I've also removed the `process.nextTick`, is this an okay solution?
I can't seem to reproduce express below 4 returning a `req.host` of `::1`. Here are the outcomes for these properties in different versions of express: With the following express app:...
Have you had a chance to review this?
Ohh that always takes longer than you want it to. No rush - good luck!
I've not had a chance to revisit this recently. @dougwilson mentioned that `req.vhost.host` is incorrect after the changes, but i'm not sure what changes need to be made.
I like the environment variable approach, then your code can stay the same and you dont have to add anything for your test environment. If we don't like the all...
Hey! Mind sharing your full code? The following works for me (and correctly 401s): ```js const sdk = require("api")("@developers/v2.0#1yl2ql5lb604m"); sdk.auth("user", "pass"); sdk .getAPISpecification({ perPage: "10", page: "1" }) .then((res) =>...
Hey Ben! :) thanks for the update on this, I'll be sure to follow along here for any future news. Let me know if I can help with testing anything....