Dom Christie

Results 69 comments of Dom Christie

> Would a PR to slim down jsdom as a new package, or as an internal dependency, be accepted? > ditching jsdom all together will give the most performance improvements....

> I'm beginning to think that the best approach might be to implement a Bring Your Own Parser for Node.js environments I should add that this is sort of already...

Yes, technically JSDOM is only required in node.js environments when the input to `turndown` is a string. In practice, the [current implementation](https://github.com/domchristie/turndown/blob/master/src/root-node.js#L6-L18) `require`s it by default so that it can...

https://github.com/montagejs/minidom looks ideal for what we're after. With only a couple of changes, I have it running with 235/241 assertions passing. Most the failures look like they're to do with...

Down to 3 failing tests due to whitespace issues: https://github.com/domchristie/turndown/tree/minidom

All tests are passing on https://github.com/domchristie/turndown/tree/minidom. I think I'll cherry-pick a few a commits from there into mater so that the library is mostly compatible with DOM Level 1 (+...

> I'm not familiar with turndown's internals, but I guess if turndowns receives a dom node rather than a string then maybe there's no need to require jsdom at all....

Nice ideas. > IMHO the best case scenario would be that the library maintains backwards compatibility but gets significantly less heavy. This would be ideal. > Are there any important...

@Vaelatern out of interest, which build are you importing, and how are you importing it? (I'm thinking in terms of https://github.com/domchristie/turndown/issues/265#issuecomment-447590252). If you're using a browser build, I suppose the...

Just to clarify, are you including `` directly in your page rather than including it (via `require`) as part of a compiled script? I'm wondering if there are any nice...