sddophin

TargetNotifiers should not use unlimited string

1

Sql Server and other database are not very efficient if you use type: "nvarchar(max)", Your just added a new column to AbpUserNotifications and AbpNotifications, TargetNotifiers There is not reason to...

Provide ability to set cache size limits and mark entries as permanent

1

Memory cache implementation should expose existing net core functions to control cache size. Use case: to make sure host machine does not run out of memory. See how at https://docs.microsoft.com/en-us/aspnet/core/performance/caching/memory?view=aspnetcore-6.0...

Loading localization resource on demand

1

There is a way to add new localization as documented here https://aspnetboilerplate.com/Pages/Documents/Localization In a large system, some strings only needed when module is loaded on the server or client. -...

Consider adding async versions of EventHandler to IOnlineClientManager or async version of IOnlineClientManager

use of nvarchar(max) is not needed

1

Consider this blog https://hungdoan.com/2017/04/13/nvarcharn-vs-nvarcharmax-performance-in-ms-sql-server/ Everytime you do not specify max like this [StringLength(AbpTenantBase.MaxTenancyNameLength)] public string TenancyName { get; set; } SQL generated is nvarchar(max) which means when database is queried...

For webhook send attempt store, there is get and insert, update but no DELETE. One might not want to keep the history of all send events. Consider to add delete...

DynamicProperty use of int as key

1

For a large project, one can run out of ints for dynamicproperty as it grows, why not use Guid?

checking for unique property name

1

Consider check for unique property name with IDynamicPropertyManager as get by name Get() returns only first.

Secure private key with passphrase when exporting

2

Once private key is exported is not secure. Proposal to add ability to encrypt the private key using a symmetric encryption key derived from a passphrase and then decrypted again.

If you update types "@types/google.visualization": "0.0.66", to latest version 0.0.66 VisualizationSelectionArray which is used by this lib is not there anymore