Tanguy ⧓ Herrmann

``` errMessage := "registered service is not a runnable" app.logger.With("service", srv).Error(errMessage) return errors.ConfigError(errMessage) ``` _Originally posted by @darioAnongba in https://github.com/ConsenSys/quorum-key-manager/pull/214#r679015962_

Currently, the app doesn't call the `runnable.Close()` function on the services when [it closes itself](https://github.com/ConsenSys/quorum-key-manager/blob/11daa183ba2c22867cd0b9540d482b5529b89db2/pkg/app/app.go#L311-L315)

We could remove some of our error handling code using the stdlib `errors` package and wrap the errors to check if they are/wrap of specific type/value. That would make it...

Currently, the make targets dependencies are not completely well modeled and the documentation is lacking which makes it hard to understand.

For now, it seems `runnable.Error()` is barely used, and clearly not used at the app level. What should we do with it, when should we call it?

Support for Go codebase

2

I love those kind of visualizations. Do you plan support on Go codebase? Do you know if it could be somewhat trivial if somebody jumps in your codebase?

Hi, I would like to use your project (instead of phpLDAPadmin), but I wish there was tags in the docker hub so I could make sure I can upgrade it...

You saved my ass and countless hours of searching. I couldn't access a server which was in a bad reboot state after the latest openssh update. I already spent 5...