Mathijs de Bruin

Results 237 comments of Mathijs de Bruin

@dosu Is there perhaps a more elegant and readable way to implement the same functionality?

@devangtomar Thanks for the contrib! However, as we're looking to remove our own oauth client implementation in favour of some third party library (#1240), we're not going to invest a...

> > @devangtomar Thanks for the contrib! However, as we're looking to remove our own oauth client implementation in favour of some third party library (#1240), we're not going to...

I realise now that we should be mindful of replay attacks in this case. The generated link can be re-used as long as it's not expired. A better approach might...

> I've managed to work around it, but it isn't pretty. This is what I did: > > create new init_chainlit.py: > > ``` > from fastapi import Request >...

Thanks for the feedback. This is a known problem and we're working on it. Basically, we should sanitise (e.g. turn into URL-safe ASCII) avatar URL's client-side. What's pending: https://github.com/Chainlit/chainlit/pull/1420#discussion_r1799680649 I'm...

Classing 🤠 stuff. Thanks for pointing this out folks! Saved my day. Actually, having request data available has been on my wish list for a long time but yes, docs...

Thanks for the feedback! I think what I missed, specifically, is having Python stdlib imports first, then other imports and finally internal/project imports. AFAIK `ruff check --select I --fix` does...

@EWouters Didn't want to pass you by but also wanted to 'clean house' in terms of PR's, so I rebased your PR minus formatting (prefer to first have clear standards,...

@JCMarques15 Friendly poke. :)