Mathijs de Bruin comments

Results 255 comments of


                                            Mathijs de Bruin

Multi-select Checkbox

@kvnn Any chance you could resolve pending merge conflicts, so we can do a final review and get this in! Sorry it's taken so long, I just joined the team...

Multi-select Checkbox

From now on expect a reply of 1-3 days. :)

Fix logger in SdJournal, add optional filters and Docker journald tags

*poke*

Install fails on Mac

P.S. GREAT STUFF! ^^

Consistent flattening behaviour for empty slices in structs

Hi @mediocregopher, Thanks for the feedback! Let me try and reflect this so we're both sure we're talking about the same thing. Currently a struct containing a slice (e.g.`[]struct` but...

HIGH SECURITY VIOLATION in cypress/support/utils.ts

Looking at the code it, I don't think there's a trivial work around. Nor an underlying security issue! Note: "[...] if the input is user controllable." In the CI context...

HIGH SECURITY VIOLATION in cypress/support/utils.ts

Closing this as it's a false positive (see comment before).

fix: resolve #828 by updating websocket's thread id header with currentThreadId to ensure session continuation after backend restart

@qtangs I just tried to replicate the issue but I was unable to reliably do so. First, I followed steps in your bug report -- but I guess we need...

fix: resolve #828 by updating websocket's thread id header with currentThreadId to ensure session continuation after backend restart

@qvalentin You seem to have a lot of grip on this issue. Any chance you might be able to double check whether it resolves it for you?

fix: resolve #828 by updating websocket's thread id header with currentThreadId to ensure session continuation after backend restart

@qtangs Thanks for your patience and contrib! ❤️