Jonas Dohse comments

Results 7 comments of


                                            Jonas Dohse

`cargo add` disables previously enabled features when converting between `_` and `-`

I created a fix for this issue. I did not follow the route of doing fuzzy lookups within `cargo add`, but just repeat the workspace existing dependency lookup and workspace...

Fix cargo add behaving different when translating package name

Yes, this PR should be ready. I need feedback to my responses (@epage). I would take another look at my TODOs when the general direction of the fix is clear.

Fix cargo add behaving different when translating package name

I responded to your comments - I will also rebase this PR. > In looking at the responses, its not clear to me what I needed responding to. Sorry -...

Fix cargo add behaving different when translating package name

I hope that I addressed the comment. [I am also now only check permutations that are unique](https://github.com/rust-lang/cargo/pull/13765/files#diff-7d08d5b8dd5fdeaca6bb19b814d06790d42f63f052b42a41f3eb5cf8ec89456cR471)

Fix cargo add behaving different when translating package name

I changed the comments according to the discussion.

Fix cargo add behaving different when translating package name

I updated the comment. I also removed the `.dedup()` of the combinations - it would not prevent all lookups of the unmodified original basename.

Use nan to support node 0.12

@leedm777 I updated this PR accordingly