dodexahedron
dodexahedron
> I know :-) I just mentioned that the dotnet team could implement it in `List` so as not to force the use of `ObservableCollection`, because this one, for example,...
I think one issue that will crop up in use, and in more places than just trying to use Microsoft.Extensions.Configuration (though that's a big one), is the custom Json serializer...
You know... I just realized you are talking about another internal type, not the M.E.C. ConfigurationManager. Just note that my previous comment was from that perspective. Anyway, thanks for the...
> I really wanted to be able to annotate members to determine what was a setting and what wasn't. I couldn't figure out how to get M.E.C to do that....
Well I kinda mean it all orthogonally to CM (which I wasn't even aware of til yesterday). While yes, unification there is probably a laudable goal at some point, there...
.net 7 and up have a shortcut method for this check, to avoid a bunch of boilerplate if blocks: `ObjectDisposedException.ThrowIf(bool condition, object instance)` https://learn.microsoft.com/en-us/dotnet/api/system.objectdisposedexception.throwif?view=net-8.0#system-objectdisposedexception-throwif(system-boolean-system-object) The condition is typically a boolean...
Might sound like it, but really it's one line per property accessor, and one private instance boolean field for each type. It's a safe copy/paste job, too, since there's no...
Oh, and any events on an IDisposable type should immediately abort before invoking their delegates, if the object has been disposed (can optionally remove them, too, at that time).
In any case, the addition of that Disposing event you added in your PR already is a big improvement for consumers. Thanks for that! :)
That'd be just as many lines for the attributes (1 per property) and then also the attribute class, so it would be a little more work. Plus that'd be non-standard....