Amelia Dobis
Amelia Dobis
I'm not entirely sure what you mean by adding support for them. Aren't ready/valid signals simply considered as regular ports? What exactly is missing that we would need to add...
I just noticed that `favorited` and `muted` are also always null...
The [blocking PR](https://github.com/llvm/circt/pull/6974) has been merged in and should be included in the next firtool release, which would make this work.
The new [firtool release](https://github.com/llvm/circt/releases/tag/firtool-1.75.0) now supports everything that is needed for this PR!
This is really easy to do using Chisel blackboxes, which is in a way similar to how it feels in cocotb. The main issue is that our tool is reliant...
What I meant is that we mostly depend on very few features from ChiselTest, i.e. the peekpoke interface. If we were to implement that ourselves, we wouldn't be dependent on...
I see that now, sorry I thought this had been solved
> Thanks for the review. I fixed some of the problems you pointed out and left comments above regarding the parts I am not sure about. > > > I...
Hi, thanks for the review! > I hope you don't mind _me_ doing a review again despite my limited knowledge on the verification stuff. For starters, I'm not entirely sure...
Thanks for all the comments!! I will go back to the drawing board and rewrite this pass as a backwards walk from a `verif::AssertOp`. That way I will have access...