Dominic Evans

Results 280 comments of Dominic Evans

@leogr I intentionally patched my sysdig source so I could build and use the same libs version as falco for testing

Nice, with a few extra commits to account for the updates that were missed, we're impressively getting a fully passing suite :)

@trapped yeah, now it is in a passing state maybe squash the commits on this branch down into a single one and then have a quick think about whether this...

@trapped 😅 well it was just an initial idea, so don't discard what you have here, but if you have time and motivation then feel free to give it a...

@trapped thanks! One thing I forgot to take account of in my original snippet was that maxVersion supported by the remote broker can and will exceed the max version of...

@shawnHartsell are you happy to assign a reviewer from amongst the codeowners?

@aethir-paas as per above, Sarama will only send the token for _authentication_ when requested by the broker, which by default is only on initial connection / re-connection. Sarama calls your...

Closing this as assumed to be resolved. Please re-open if this is still a problem for you

Yes so this was pinned to 1 as part of https://github.com/IBM/sarama/pull/2375 which aimed to control memory usage because the prior default behaviour had been to allocate 1 per goroutine. So...

@HenryCaiHaiying thanks for the PR. On a general note I _think_ we would want to be similar stdlib naming with MaxIdleEncoders rather than MaxBufferedEncoders. However, I also wonder whether @klauspost...