Serge Latyntsev

Results 34 comments of Serge Latyntsev

> I am open to better solutions that I can apply to my own code as well. If you need it lossless, that functionality is implemented in the [fraction](https://github.com/dnsl48/fraction) module....

> t's possible that we could replace it with something like a `SiteTreeState::singleton()->withState(function ($newState) { $newState->setRunCMSFieldExtensions(false); $this->doStuff(); });` Don't see a lot of value in refactoring this particular bit of...

There is a bit of documentation about it - https://github.com/silverstripe/silverstripe-cms/blob/4/code/Model/SiteTree.php#L2922-L2923 It seems to be solving rather an edge case when a deriving class wants to override `getCMSFields` method, call `parent::__getCMSFields`,...

> I say weird because it is hard to understand for me how this works and why a call back is used rather then just normal code I think that's...

This is SS 4.3 regression

Thank you for the contribution! I don't think there are any implications for the existing code anyway, so that should be alright.

Looks like this project is long gone. It's not gonna work with php > 7.1. Here's a fork that seems to be working with php >= 7.4: https://github.com/zobo/vscode-php-intellisense

sure, will do, thank you for taking a look :)

Hey @GuySartorelli, sorry, I don't remember the exact details. Looks like everything is okay as is without this patch :)

Hi! Thank you for reporting this. Would you like to make a Pull Request?