silverstripe-behat-extension icon indicating copy to clipboard operation
silverstripe-behat-extension copied to clipboard

Published 20 hours ago • verified publisher icon silverstripe

FIX | TestMailer uses new testsession APIs for handling state

Open dnsl48 opened this issue 6 years ago • 2 comments

This PR is a follow up on https://github.com/silverstripe/silverstripe-testsession/pull/65

dnsl48 avatar May 17 '19 00:05 dnsl48

Would you mind fixing the builds to ensure they're still green?

This branch is for SilverStripe 5.x, so you may want to retarget the PR. The Travis config needs recipe constraints changed from 2.x to 5.x

robbieaverill avatar Jun 13 '19 21:06 robbieaverill

sure, will do, thank you for taking a look :)

dnsl48 avatar Jun 13 '19 21:06 dnsl48

@dnsl48 Do you know what specifically this was solving? Was there a bug that this fixes? I'm inclined to close this PR given we've been running behat tests for 4+ years since the PR was opened and this hasn't seemed to be a problem.

GuySartorelli avatar Dec 14 '23 03:12 GuySartorelli

Hey @GuySartorelli, sorry, I don't remember the exact details. Looks like everything is okay as is without this patch :)

dnsl48 avatar Dec 14 '23 20:12 dnsl48