dnoneill
dnoneill
see https://github.com/geoblacklight/geoblacklight/pull/1555
fix here: https://github.com/geoblacklight/geoblacklight/pull/1445
Created tests for geoblacklight instance but realized that due to the bl8 branch not working we can't run the tests against that and the tests on main reveal errors that...
closed with https://github.com/sul-dlss/earthworks/pull/1268
Is there a reason we aren't using an event in https://github.com/sul-dlss/sul-embed/blob/main/app/javascript/controllers/companion_window_controller.js#L13 that the geo controller would know to listen for and wouldn't init until it triggers? The behavior might be...
This is actually a spotlight bug.
I will need a little time to dig, but right now this looks almost the exact same as what I was seeing in: https://github.com/projectblacklight/spotlight/pull/3197
@corylown, 91% sure this is solved with https://github.com/projectblacklight/spotlight/pull/3197
Should be fixed with https://github.com/geoblacklight/geoblacklight/pull/1649
@taylor-steve I think this is being done. Right now each item in the sidebar is checked for it's auth settings.