Dimosthenis Nikoudis

Results 18 comments of Dimosthenis Nikoudis

Personally, I'm not a fan of the static variable approach. I think injecting it to the bootstrap or bridge would be a good approach (maybe via a `setLoop` function and...

I remember this issue and its a tricky one, because, on the one hand, the behavior is correct (the slave should definitely not handle any more requests after the exception)...

If you ask me, ideally the behavior should be that if debug is true it would return the exception message and the stack trace to the browser, while if its...

It seems to make some tests fail with 503 error "no slaves available". Is it possible this PR introduces some scenarios where the worker does not respawn when it should...

There is already something for this in travis from what I can see https://github.com/php-pm/php-pm-httpkernel/blob/master/.travis.yml#L20 Is this just a matter of adding `composer create-project laravel/laravel blog` and `composer create-project symfony/skeleton blog`...

Leaving Travis aside, what are the steps to reproduce those issues from scratch? 1. Create Symfony/Laravel project 2. cd to created project folder 3. composer require php-pm/httpkernel-adapter (with some fiddling...

Actually now that I think of it, can't we just replace the line in travis.yml: `composer require --dev "symfony/symfony" "laravel/framework" "drupal/drupal"` with: `composer require --dev "symfony/framework-standard-edition" "laravel/laravel" "drupal/drupal"` This will...

That looks strange indeed. I'll try to have a look in the next few days, as this will probably affect my projects as well after upgrading. The PHP-PM code itself...

Btw, if DoctrineBundle now performs its own reset we should probably remove our reset logic in PHP-PM's postHandle or make it conditional on `Doctrine\Bundle\DoctrineBundle\Registry` not having `ResetInterface`. Otherwise we are...

@saghul yeap, I signed it back when I made this PR https://github.com/jitsi/jitsi-meet/pull/13939 . I just redid the process to be 100% sure.