php-pm-httpkernel icon indicating copy to clipboard operation
php-pm-httpkernel copied to clipboard

Add CI tests if PR is installable with Symfony and Laravel

Open andig opened this issue 7 years ago • 4 comments

andig avatar Sep 16 '18 10:09 andig

There is already something for this in travis from what I can see https://github.com/php-pm/php-pm-httpkernel/blob/master/.travis.yml#L20

Is this just a matter of adding composer create-project laravel/laravel blog and composer create-project symfony/skeleton blog

in the script section in travis.yml?

dnna avatar Sep 17 '18 10:09 dnna

Noticed the need during https://github.com/php-pm/php-pm/pull/431.

Is this just a matter of adding...

The tricky part is installing the current PR into the generated framework project. Only approach I could find was fiddling with local composer repositories (https://getcomposer.org/doc/05-repositories.md#path)?

andig avatar Sep 17 '18 10:09 andig

Leaving Travis aside, what are the steps to reproduce those issues from scratch?

  1. Create Symfony/Laravel project
  2. cd to created project folder
  3. composer require php-pm/httpkernel-adapter (with some fiddling with composer repos to ensure this pulls the PR instead of the live version)

Are these the correct steps to test?

dnna avatar Sep 17 '18 13:09 dnna

Actually now that I think of it, can't we just replace the line in travis.yml: composer require --dev "symfony/symfony" "laravel/framework" "drupal/drupal" with: composer require --dev "symfony/framework-standard-edition" "laravel/laravel" "drupal/drupal"

This will widen the scope of the dependencies to what the actual frameworks install and should catch those conflicts.

Edit: To be more correct we should split this line to install laravel, symfony and drupal separately, since each framework may install conflicting dependencies with each other.

dnna avatar Sep 17 '18 13:09 dnna