David Nesting

I suspect the culprit is at https://github.com/Clever/microplane/blob/master/push/pushGitlab.go#L52. The GitLab merge request options should include an `Assignee` up front (see https://github.com/xanzy/go-gitlab/blob/master/merge_requests.go#L561), but it looks like only a handful of elements are...

It looks like this should be possible using the [GitLab Approvals API](https://docs.gitlab.com/ee/api/merge_request_approvals.html). Maybe: ``` GET /projects/:id/merge_requests/:merge_request_iid/approvals { "id": 5, "iid": 5, "project_id": 1, "title": "Approvals API", "description": "Test", "state": "opened",...

To be clear, both of these conditions currently result in `NotFoundError` responses to the `Update*` methods in the go-unify client: 1. HTTP 404 2. HTTP 200, `rc: "ok", data=[]` The...

Idea: Manually work out what conditions mean some fields are required, optional, or should be suppressed, and find a way to suppress them when serializing (json `omitifempty`?). Maybe something like:...

Idea: At least with the Network type, the field sets for `purpose:"LAN"` and `purpose:"WAN"` are completely different. Maybe there needs to be two separate objects, like `LANNetwork` and `WANNetwork` that...

Trying to work out how the web UI does this, I found in `app.js` code like this (for the 'network' save operation): ```js angular.module("app-unifi-manage").controller("NetworkFormLanController", ["$translate", "CollectionView", "devices", "deviceFeatureUtils", "deviceUtils", "dhcpOptions",...

Ugh it's even more complicated than that. Somewhere it's actually treating things like "WAN" and "LAN" as distinct data types, so we have an entirely different set of operations that...

This may be clarified by https://go-review.googlesource.com/c/oauth2/+/493335. There are three places contexts can be used here: ``` httpClient := oauth2.NewClient(newClientContext, c.TokenSource(tokenSourceContext)) req = req.WithContext(reqContext) httpClient.Do(req) ``` - `newClientContext` is used to...

Resurrecting this issue. I was going to open a new golang proposal, but now that I found this issue I'll start here and see if people have comments. I believe...

I've implemented the above at https://github.com/golang/oauth2/compare/master...dnesting:oauth2:dnesting/token-context if anyone wants to experiment.