Datong Sun comments

Results 71 comments of


                                            Datong Sun

ngx.resp.get_headers(): Why is the response header incomplete?

Hello, Nginx in general stores headers in a linked list. But this has a drawback of changing and accessing a header requires traversing the list to find it which may...

bugfix: sanity checking in ngx.timer.at delay param

This particular change is probably fine to be enabled by default as the cost of comparison is practically negligible compared to the cost of creating a timer.

fix(tracing): correct matching ot baggage headers

Merged, thanks for your contribution @pathak1515 !

could not rebuild router via timer: could not create router: concurrent incremental router rebuild without mutex, this is unsafe

Hello, Could you provide more information on how to reproduce this?

feat(clustering) add cert exp date for clustering dp endpoint

@artomal any updates on this, should this be marked as ready for review?

feat(clustering) add cert exp date for clustering dp endpoint

Ping @fffonion ^^

feat(clustering) add cert exp date for clustering dp endpoint

@wyndigo we created a card to track adding this functionality into Prometheus internally. I removed the comment from @fffonion because it contained internal information.

perf(clustering): use privileged worker for control plane connection

Can we measure the performance gain of this change @ADD-SP ?

chore(cluster) Bump "reconfigure" event log level to info

I don't feel this PR is really that useful, and it might generate noisy logs entries too.

fix upstream_dict nil while updating an upstream

@ranxuxin I applied all those suggestions and rebased the PR to make it follow our styling better. Feel free to take a look! Also added a minor performance improvement by...