David Moravek

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=56312&view=results

Can't reply inline for some reason :) > I had in mind [this line](https://github.com/dmvk/flink/blob/1f8b6548ee3686d38a23024b0de474aaf869007d/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/DefaultSlotPoolServiceSchedulerFactory.java#L200) That's for the batch scheduler. > OT offtopic haha :D

fyi @echauchot @dawidwys

CI seems broken by https://github.com/apache/flink/pull/24022#issuecomment-1888811191

`testOperatorEventLostWithReaderFailure` ... reliably fails when trying to restore from compressed state, will investigate further :/

I've been able to pin down the issue to https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorStateRestoreOperation.java#L190 the problem is that the sorting breaks on empty state ... we should always restore in the order state was...

And another one ... this just hurts :/ `DataSetSavepointReaderITCase.testOperatorStateInputFormat`

hmm, so the issue is related to repartitioning in case there are multiple states; imagine we have two states with 6 elements and we rescale from 1 to 3; this...

Fixed in https://github.com/apache/flink/pull/24079/commits/6bb32b114b76515757e602612dcf33668d031fef I think this needs another review pass now. Can you please take another look @isburmistrov @dawidwys ?

Note that the latest fix (https://github.com/apache/flink/pull/24079#issuecomment-1892858467) is not BW compatible, but I don't think there is any harm in that since the snapshots were not restorable anyway.