flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-33973] Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API

Open pvary opened this issue 1 year ago • 4 comments

What is the purpose of the change

Add new SinkV2 API interfaces, set inheritance and deprecation for the old interfaces.

Brief change log

All the new API's defined in FLIP-372

One minor additional change:

  • Added map to CommittableSummary and CommittableWithLineage so it will be easier to map when the types are changed.

Verifying this change

The existing tests should run without issue, to verify the backward compatibility.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? not documented

pvary avatar Jan 03 '24 12:01 pvary

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jan 03 '24 12:01 flinkbot

@flinkbot run azure

pvary avatar Jan 09 '24 16:01 pvary

@flinkbot run azure

pvary avatar Jan 10 '24 13:01 pvary

@flinkbot run azure

pvary avatar Jan 11 '24 13:01 pvary

@pvary @gyfora

This PR seems to break master.

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=56314&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=2540

dmvk avatar Jan 12 '24 10:01 dmvk

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=56312&view=results

dmvk avatar Jan 12 '24 10:01 dmvk

Thanks @dmvk strange as we had a passed CI run, @pvary is taking a look

gyfora avatar Jan 12 '24 10:01 gyfora

@dmvk we reverted that commit, seems like there was some mess-up with the passing CI / rebasing. Sorry about that

gyfora avatar Jan 12 '24 10:01 gyfora