dmurdoch

Results 222 comments of dmurdoch

@krlmlr: This is not related to `nat`, but I failed to install the new `igraph`, with this error: ``` clang -arch x86_64 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -DUSING_R -I. -Ivendor -Ivendor/cigraph/src -Ivendor/cigraph/include...

After installing `glpk`, I got the same error as shown in the "problems" link. Here's a bit more context: ``` ── Error (test-neuron.R:278:3): we can subset a neuron with a...

Could you add a simple example showing the issue? This could be added in a comment here, or possibly in a test in `tests/testthat` in your PR (though the tests...

Regarding #671: would it be possible to *also* fix that, or are these completely separate issues?

I'm not going to be able to look at this in detail for a few days. If nobody has commented on it or merged it in a week, feel free...

Thanks for the reminder. Looks like your code passes all our checks. Could I ask for one more edit? Some of the new lines are quite long; could you add...

I get the line break after xxx, but not before yyy. (The first line is wrapped in `` in the output.) I didn't have any white space at the start...

This function looks like the culprit: https://github.com/r-lib/pkgdown/blob/5a0a31f89d7c839c04a929844e4b7216196189ca/R/rd-data.R#L90-L112 It assumes that whitespace (including `\n`) following an item is a paragraph break, but the `\code{}` macro becomes an item with no newline...

Your document looks like a Quarto document. Is it?

That may be your problem. `kableExtra` was written for R Markdown. It's gradually being adapted to also work with Quarto, but that work is not complete. Since `kableExtra` hasn't had...