David Moreau Simard

Results 496 comments of David Moreau Simard

Yeah, the issue has something to do with passing the instance weakref back and forth. If I revert the [patch](https://github.com/ansible-community/ara/commit/b632aae7d82a25e3a60d834e5ccee938eddc9fec#diff-e0a8a9a7b6f45ca04a4d939a1f547329) that introduced the weakref, I am unable to reproduce the...

I haven't found a definitive fix for this yet and it didn't warrant blocking the release of 1.4, we can fix it in an upcoming dot release.

I haven't revisited this issue in a long time but perhaps this PR could fix it: https://github.com/ansible-community/ara/pull/274

Hey @hille721, thanks for the feedback

@hille721 thanks for working on this. Here's some thoughts. I think I can concede that the playbook status is not immediately relevant and can even be confusing relative to the...

> The playbook name (or path) could go after the host name, but then that pushes the host status further away > * Would ` ` work ? > *...

> Relying on colour alone is not ideal for accessibility. @flowerysong I agree. That's why I feel it's important to keep the full labels (with their corresponding colors) in the...

@hille721 I added a comment on your commit -- could you open a PR? Would make it easier to review and discuss.

If we go with the status pill implementation, I wonder whether we should only print the statuses for which we have something, not unlike what we had before, in fact....

I'll close this now that the corresponding PR has landed. It's been a worthwhile iterative improvement. Thanks!