David Moreau Simard

Results 496 comments of David Moreau Simard

> Code reviews on github are absolutely terrible compared to gerrit. This is a step in the wrong direction for open projects. @hemna The project has been hosted on Gerrit...

I've made progress and will continue later. The project is already hooked up to Ansible's Zuul (via https://github.com/ansible/project-config/pull/751): https://dashboard.zuul.ansible.com/t/ansible/builds?project=ansible-community%2Fara and I will be able to land a PR to add...

@xenlo I looked a bit and was thinking about this ... it looks a bit tricky to listen on both ipv4 and ipv6 simultaneously with the built-in web server. There's...

Unless mistaken, support for specifying certs, keys and CA has landed in the master branch via https://github.com/ansible-community/ara/pull/392 and https://github.com/ansible-community/ara/pull/403 but the CLI arg names will need to change a bit...

> It would also help if ARA did this in the client code when ARA_INSECURE_API is set: > > ```python > import urllib3 > > urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning) > ``` > >...

> Using `ara_ca` in my ansible.cfg fixed the issue for me. :-) I think this issue can be closed. ``api_ca``, right ? There is no such setting as ``ara_ca``. Same...

@hille721 good find and I think you have the right suggestion for the fix. Thanks !

@hille721 I added a comment in the PR. There is nothing that currently tests host facts so it's a gap in the testing coverage. If you'd like to add a...

It's likely that 0.x has a similar issue, @pabelanger shared this trace: ``` 2019-06-13 14:15:12.491754 | TASK [Generate ARA HTML output] [2019-06-13 14:15:21,132] ERROR in app: Exception on /result/e7ea405b-e824-4969-995f-45207985e7e7/ [GET]...

@pabelanger The failure case for 0.x is different than the one from 1.x. In 0.x, the data is saved properly to the database by the callback and you get the...