Damien Seguin

Results 165 comments of Damien Seguin

> From my understanding some older devices might not support `highp`. I've never heard of a device not supporting `mediump`. I would imagine the `getShaderPrecisionFormat` for all precisions is there...

From this: ```js if (!gl.drawElementsInstanced) { const ext = gl.getExtension("ANGLE_instanced_arrays"); if (!ext) { // TODO: this._caps[CAPS_INSTANCED_ARRAYS] = false; gl.drawElementsInstanced = () => { throw new Error( "gl.drawElementsInstanced not available. ANGLE_instanced_arrays...

OES_element_index_uint and OES_standard_derivatives still need a call to get activated.

Does it matter if the value is right but not coming from the the pex-context enums?

Is there any advantage over the current `checkError()`?

I would keep crashing and enhance the error as much as possible.

I'd say yes, warning in pex-context but also overwrite supportImageBitmap by checking isWebGL2 in pex-renderer.

> Why do we not support in in gltf in Safari? Because it doesn't support `options.colorSpaceConversion` which is GLTF spec: https://developer.mozilla.org/en-US/docs/Web/API/createImageBitmap#browser_compatibility FF >= 98 supports it so I didn't added...

Proposed change: check if ImageBitmap in webgl. ```diff } const img = opts.data ? opts.data : opts; - if (img && img.nodeName) { + if ( + (img && img.nodeName)...

You need to enable `EXT_color_buffer_float`: https://developer.mozilla.org/en-US/docs/Web/API/EXT_color_buffer_float https://github.com/pex-gl/pex-renderer/blob/f642330f86157dd7169843f44482a5b0b634124b/index.js#L82-L85