David M. Lloyd

Results 306 comments of David M. Lloyd

> So I love this, but I have a suggestion. It'd be cute to auto-convert the png to ascii art for the cases where this doesn't work. That saves people...

In terms of startup time, according to my highly unscientific measurements, my simple getting-started example starts in about ~320ms with the banner and ~310ms without it. So, there probably is...

So for some reason I spent some time tinkering with an alternative text-based banner. I started with this analysis: ![quarkus-grid](https://github.com/quarkusio/quarkus/assets/124581/79406f09-c73e-4477-94e5-86cd659f9ae1) I wrote a crappy image interpolator which gave me this...

I just determined the width as a function of the original image aspect ratio, based on 5 rows and a font aspect ratio of 3:5 (which appears to be more...

Yeah, it's tricky when it's scaled down. I'd be hesitant to go much higher than five rows of text let alone 100 😉. Even just doing the letters, it doesn't...

Pushed. Now we have separate config for graphical banners, plus a separate switch. Also some knobs for adjusting the size, and a default graphical banner. I've also updated the text...

Oh, to enable at run time use `-Dquarkus.banner.image.enabled=true`. Maybe we should make it the default? (It'll still be disabled if the console does not appear to support graphics though...)

The above text banner does indeed look bad on Windows (missing Unicode characters). This one looks OK in `cmd.exe`, though it's even lower resolution: ```text ▄█▀▀█▄ █ █ ▐█▌ █▀▀▀▄...

Don't worry @maxandersen, as I said before, it won't attempt to display the banner unless there is a high confidence that it will work, even if it is explicitly enabled.

@insectengine did you have any thoughts about a transparent-background, PNG-format version of the banner that looks good on both light and dark backgrounds? Alternatively we could have separate config for...