David M. Lloyd

This seems like a legitimate bug to me. I should have added a check to see if there was a converter for the given type before assuming it was a...

I think you are right: unless you know ahead of time which interfaces have a converter, you would need the explicit annotation. Hypothetically you could replicate the discovery process of...

I think this trades one problem for another. If there's a specific parsing mode that we need for expression strings then it should be implemented directly in `smallrye-common-expression`. The optimization...

> @dmlloyd it seems like there isn't a great way to do this. The comment > > https://github.com/smallrye/smallrye-config/blob/889fa9ffb91cd44d3d4b77e82b39c9cb81fc7750/implementation/src/main/java/io/smallrye/config/ExpressionConfigSourceInterceptor.java#L94 > > seems to make it clear that the more general handling...

Adding on to that, I think MP Config's treatment of `\$` is an error as well, precisely because of how it interferes with traditional expression syntax, converters, *and* the properties...

> @dmlloyd slightly related to that, I'm not very happy about how we deprecated the package config properties: > > * the warning is not really actionable: you get a...

> I guess this fixes this right? > > ``` > [INFO] --- quarkus-maven-plugin:999-SNAPSHOT:build (default) @ getting-started-reactive --- > [WARNING] [io.quarkus.deployment.configuration] Configuration property 'quarkus.package.vineflower.enabled' has been deprecated and replaced by:...

Ah. I started my patch before `vineflower` was renamed to `decompiler`, and that one did get missed.

A few things (I'll make it a checklist): - [x] ~~Wait for a new release of `kitty` to be out for a little while and drop the `ImageIO` stuff~~ (This...

> Neat. > > Is the idea to have a default PNG or just to let users provide one? As stated above, I think it would be nifty to have...