David M. Lloyd

Results 306 comments of David M. Lloyd

The CSR is [JDK-8335438](https://bugs.openjdk.org/browse/JDK-8335438).

> Is there a high level description of how these methods would be used? They would be used identically to how the `readObjectForSerialization` and `writeObjectForSerialization` methods are used. The caller...

> The tests should include serializing some sample JDK classes that include a hierarchy of 2-4 levels. It would help fles any interactions in the sequencing of calling the default...

Could anyone provide a second review? I'm hoping to get this finished before rampdown for 24, which is about 8 weeks away now, and there are still a few steps...

The test failures seem unrelated, if I'm reading these logs correctly.

I think I'm just needing two reviewers now (and a sponsor after that). It's close!

The failure on Mac is some kind of tooling setup error: ``` xcode-select: error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer' ```

@arcivanov commented [[email protected]](https://issues.redhat.com/secure/[email protected]) Do you have any thoughts about a possible cause?

@dmlloyd commented I think it probably will come down to poor filter optimization. I think if complex filters had smarter comparison/hash operations the sets might collapse better, but that's just...