David M. Lloyd

Results 306 comments of David M. Lloyd

:+1: it's probably better to keep the fix down to the thing being fixed when possible.

**[James Perkins](https://issues.redhat.com/secure/ViewProfile.jspa?name=jamezp)** commented I've changed the priority to critical because this could lead to an OOME if the message queue gets too large.

An important feature of this proposal, and an important limitation of using the BV annotations, is that by giving our min/max values as a string, we can apply the same...

The annotations should apply at the same scope as the `@WithConverter` to appropriately decorate it, so for example I could have a property like: ```java List myPositiveIntegerList(); ```

Quick view link: https://github.com/dmlloyd/wildfly-proposals/blob/wfly-10418/embedded/WFLY-10418_Context.adoc

Oops, I forgot that `cc` is a Skara command. Sorry, bot.

I've updated the PR with a new access control solution, but it's not ideal since it involves internal reflection. To solve this issue, unless I'm misunderstanding something, I think we...

I added a commit which moves the bytecode gen to the JLI package and accesses it via SharedSecrets, which is reasonably similar to what other methods in ReflectionFactory are already...

> I skimmed through the latest update ([d137f43](https://github.com/openjdk/jdk/commit/d137f43b00e935e9fbcaeaa80fdff93a0a2df44b)) and I think you've got this to a good place and a sensible/workable proposal. I've asked from help from others on the...

> /csr > > Since this is an API addition, this will require a CSR; Valhalla folks can check if this API is future-proof in the CSR. According to https://wiki.openjdk.org/display/csr/CSR+FAQs,...