Dmitry Lyzo

Results 121 comments of Dmitry Lyzo

> Oh... I think i made a mess... > > I don't know if I actually squashed the commits correctly. What should I do in this situation? - `git checkout...

I moved some changes to the first commit: https://github.com/dmitrylyzo/jellyfin-webos/tree/fix-json-crash _By using `edit` when rebasing. There were few minor conflicts._

> Nice! Do you think something is missing or is it ready to be merged? If you don't mind, I can force push the branch I posted to your master.

@samcon If you are in DevTools, please look what the value of `deviceInfo.screenWidth` before https://github.com/jellyfin/jellyfin-webos/blob/07a266001f7dccb6a10b933a7239394c17956b3e/frontend/js/webOS.js#L51 If it is `1920` and `devicePixelRatio: 2` then it works as expected.

> `deviceInfo.screenWidth` is already 3840 before ` deviceInfo.screenWidth = Math.floor(deviceInfo.screenWidth * devicePixelRatio);` devicePixelRatio is of course 2. Hmm. So is it scaled to 7680 after? Do you see `4K` options...

> I'm on nightly (server and web) and I don't have "Video Settings" in that screen (only Audio and then Advanced). That mode is still only in the release branch....

> I definitely agree that any embedded subtitles should not be used with text based ones. > Right now I'm getting the valid secondary subtitle list is generated with `secondarySubtitleTracks`...

The problem is that `px` is always `px`. With a small font, the shadow starts to look oversized. As has been said, to show the UI changes, it is better...

What they look like now. ![subs-em4-wide](https://user-images.githubusercontent.com/56478732/167614997-044ba61e-3527-4653-9044-5217905c35e3.png)

I think the shadows are still too thick - the contrast hits the eye. ![test1](https://user-images.githubusercontent.com/56478732/167668345-0cd7cf5f-00ce-4b0a-9a4b-000bd736499a.png)