Dmitry Timofeev

Results 100 comments of Dmitry Timofeev

I've mistaken the definition — these macros aren't actually exported :upside_down_face:

> I thought about whether it might be better in a separate crate, however as far as I could tell this would be problematic because the jni-rs dependency would constantly...

> Thanks, I think we shall figure out a couple of design questions: Do I understand correctly that most usages of wgr come in the following form: ```rust // Initialize...

Can't `as_obj` be used to retrieve a JObject from the GlobalRef and pass it to `new_local_ref`? Agree that it must be possible to pass GlobalRefs to most JNI APIs. The...

Are there any issues with two _separate_ hierarchies of errors? Is it a good practice in Rust to keep errors coming from two different types (JNIEnv and JavaVM) but the...

> There was also a consideration on too restrictive lifetimes (also in #38) Also, doesn't it make sense to extend the lifetimes? My understanding is that with such lifetimes it's...

> As far as I can see, the lifetime should be bound to a class Yes, the lifetime should be bound to a Java class. However, for the avoidance of...

Hi, @johnwalker , I think it's an awesome initiative. Including it in the project will extend the audience to all (prospective) users; and will make it more likely to stay...

Awesome! I'd certainly keep the tutorial code in the main repo in a separate module, so that in case of any changes to the API the tutorial code is also...

> Let's do something similar to that! Agree! > It sounds like you've come up with a similar approach We did a prototype of a very similar approach, building on...