Dmitry Savintsev

Results 42 comments of Dmitry Savintsev

thanks @unphased - your diff was helpful, please do submit a PR! :)

never mind - noticed the PR from https://github.com/showgood/LibToolingExample (Kevin, please merge it or @unphased's one!) :)

sorry there were more changes that necessary - thanks for double-checking (I'm glad I used a PR :) ) I reverted the lines that you commented on. See if you...

I see that conditional compilation guards need to be added around #include lines - what is the typical or recommended style? #ifdef linux ?

OK - copied the guards from the mozilla-central file, should be good now. Sorry for bunch of commits! Compiles on Fedora but I did not try it on Windows yet.

Confirmed that my repository https://github.com/dmitris/DOMinator builds fine on Windows (with MozillaBuild and pymake), tests run fine, Firefox application opens. The PR should be now fine to merge - let me...

the current version of swagger-codegen (that you get with `brew install` for example) is `2.3.1` - CONTRIBUTING.md says "use swagger-codegen 2.2.2, not newer versions". @johanbrandhorst - would it be possible...

#772 has been merged now, can we remove `swagger-codegen` now?

@mattfarina - did you have a chance to check this? I'd love to use glide-report to check for the updates.

> i'll look at this soon. thanks. @mattfarina - wanted to follow up on this; would really like to have functional glide-report, would be very useful for us 😄