Dmytro Borchuk comments

Results 6 comments of


                                            Dmytro Borchuk

[useMeasure] Ability to track a custom Ref

Hey! How do you think, should we pass a real `ref` there or just an element? ``` const {width, height ... } = useMeasure({ ref: ref }); ``` or ```...

[useMeasure] Ability to track a custom Ref

Looks like this proposal contains breaking backward compatibility. Should new PR implement it like that? Currently, it returns an array where the first element is `ref`, but with passing `ref`...

[useMeasure] Ability to track a custom Ref

@ashubham @streamich What do you think?

[useMeasure] Ability to track a custom Ref

@joeshub Great idea for the JavaScript but how TypeScript types should look like in this case?

[useMeasure] Ability to track a custom Ref

@PoOw Thank you for the idea, you are awesome! I totally forget that TypeScript has Overloads (https://www.typescriptlang.org/docs/handbook/functions.html#overloads). I will work around that solution

Are you planning to implement the possibility to trigger a fullscreen view outside of the image?

Forgot to say that the library is pretty cool even without this functionality.