David M. Golembiowski

Results 59 comments of David M. Golembiowski

> There doesn't seem to be any good reason for writer to be sized, since it's just a mutable reference. Without `?Sized`, it's impossible to use trait objects with BinWrite....

Another thing to add: "_verify links_": https://docs.rs/crate/binrw/attribute

This needs more love and attention

@msrd0 I'm also curious about this. @zesterer's suggestion seems right to me, and so it seems like [`std::iter::fold`](https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.fold) is useful, so that a `(/* line: */ mut usize, /* column:...

I noticed the line `recv_time = time.time()` near the top and I'm wondering if that might be causing your problem (but I'm not 100%). I thought Raymond Hettinger said (at...

> I noticed the line `recv_time = time.time()` near the top and I'm wondering if that might be causing your problem (but I'm not 100%). I thought Raymond Hettinger said...

Seems like this is doable. From what I've seen, the scope of the feature would apply to changes to [loop.pyx](https://github.com/MagicStack/uvloop/blob/master/uvloop/loop.pyx) and [loop.pyi](https://github.com/MagicStack/uvloop/blob/master/uvloop/loop.pyi). Hypothetically, it might need to satisfy: ```python import...

> We're obviously willing to accept such a PR. I briefly compared [Lib/asyncio/base_events.py](https://github.com/python/cpython/blob/bb3e0c240bc60fe08d332ff5955d54197f79751c/Lib/asyncio/base_events.py#L987-L1089) against [uvloop/handles/handle.pyx](https://github.com/MagicStack/uvloop/blob/master/uvloop/handles/handle.pyx#L268-L299), and believe I found the appropriate entrypoint to inject this logic. Since `loop.create_server` shares a...

Hey @mdauner, this sounds like an interesting idea. Let me take a look around and see if I can find any clean entry-points for this capability.